feat: add native Market pager headers and stabilize lists - #99
Merged
Merged
Conversation
originalix
reviewed
Sep 11, 2026
originalix
reviewed
Sep 11, 2026
originalix
reviewed
Sep 11, 2026
originalix
reviewed
Sep 11, 2026
originalix
reviewed
Sep 12, 2026
SDWebImage assigns `image` from inside its own completion, which runs before HybridOneKeyImage's generation guard and never re-checks whether the view still belongs to the request that started the load. Fabric recycles a single OneKeyImage UIView across unrelated images, so a superseded completion could repaint a slot that already shows a different one — a device avatar painted with a token logo, a network logo painted with an account avatar. Because lastRequestSignature already matched the new request, no later scheduleLoad ever repainted it back, and the 3.0.118 synchronous memory-cache path made it permanent by returning before any corrective SDWebImage request was issued. Take the set-image step back via sd_internalSetImageWithURL's setImageBlock and route every write through a generation-guarded applyDisplayedImage, so the non-nil writers collapse to a single guarded entry point. This matches the Android path, which already assigns the drawable inside its own guard. Using setImageBlock rather than SDWebImageAvoidAutoSetImage keeps the rest of SDWebImage's behaviour unchanged: the completion stays gated on `finished` (the flag would have delivered progressive partial frames through a callback signature that cannot observe it) and sd_setNeedsLayout still runs. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Minnzen
approved these changes
Sep 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3.0.123 follow-up
This branch intentionally keeps the existing iOS Image request-supersession guard in the same published commit chain and adds the Android Market pagination-anchor repair; no commit was bypassed or rewritten.
3.0.123through the officialpackage-publishworkflowValidation and publication
:onekeyfe_react-native-native-list:compileDebugKotlin: passed3.0.123and alllatesttags resolve to3.0.1233.0.123, rebuilt Android successfully, and produced runtime anchor/logger/frame evidence on its dedicated AVDSummary
CollapsiblePagerViewon iOS and AndroidACTION_UP, so later React Native banner/filter/time taps remain responsiveValidation
yarn workspace @onekeyfe/react-native-pager-view test— 2/2 passedyarn workspace @onekeyfe/react-native-pager-view typecheck— passedyarn workspace @onekeyfe/react-native-pager-view prepare— passed:react-native-pager-view:compileDebugKotlinfrom app-monorepo — passed3.0.123git diff --check— passedThe repository root has no
preparescript; the package-levelpreparecommand above is the applicable build check. Package lint remains blocked by the repository's existing ESLint 9 / legacy config mismatch.App-level Android screenshots, screen recordings, lifecycle logs, and frame-timeline evidence are tracked in app-monorepo PR #13350.
Issue: OK-62871