fix: preserve Android images during row updates and navigation - #98
Draft
originalix wants to merge 3 commits into
Draft
fix: preserve Android images during row updates and navigation#98originalix wants to merge 3 commits into
originalix wants to merge 3 commits into
Conversation
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Android account-selector balance patches rebuild the native row and clear an unchanged avatar before loading it again. React-owned images can also be cleared while Android is still drawing them during a removal transition. These changes preserve the image across both paths.
The final diff contains only three Android Kotlin runtime files. Package versions remain at
3.0.114; release/version changes and the temporary test build configuration have been reverted. There are no JS API or iOS implementation changes.Validation completed before cleanup: 87 Android JVM tests passed (Image 81, NativeList 6), including two regression cases that failed against the original
d971e760sources. The three runtime files are byte-identical to the testedbf1cd56bversions. That earlier commit retains the test harness for reference; the harness and its Gradle configuration are outside the final diff.The requester is continuing physical-device testing with the existing Android APK from App commit
4127073aed1630094b03d8c67832469c3261dd8e. The App branch carries equivalent patches against published3.0.114packages and the stable-element correction. No new build or npm publication is requested. Keep this PR in draft until physical-device verification passes.Physical-device acceptance covers repeated balance updates, device-detail exit transitions, account/image changes, recycling and foreground/background transitions. The separate asynchronous settings-row layout shift and whole-page blank-frame behavior still require verification; the code-level tests do not establish that every recorded flicker is resolved.
Related investigation: OK-62255, OK-62104.