DEN-4233: preserve UTF-8 across JSON stream chunk boundaries - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Transform decoded each incoming Buffer independently with
String(chunk). A valid UTF-8 code point split across stream chunks could therefore be replaced/corrupted before JSON parsing, including when a multibyte custom delimiter itself crossed a byte boundary.Changes
StringDecoder('utf8');café, emoji, CJK text, and a multibyte∆∆∆delimiter;Contract note
This parser is an in-process byte-to-object library, so this PR intentionally does not invent a TypeSpec/JSON Schema authority. TJSV remains required where a real serialized cross-runtime contract exists; the gRPC reconciliation repo is the audited boundary target for that enforcement.
Linear: DEN-4233