Skip to content

Remove event-triggered Type label reminders to fix race condition on issue creation #14993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 3 commits into
base: dev
Choose a base branch
from
+40 −107
Draft

Remove event-triggered Type label reminders to fix race condition on issue creation #14993

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1237f23
Initial plan
Copilot Jul 13, 2026
6b75241
Remove event-triggered label reminders [20-30] and [20-40] to fix rac…
Copilot Jul 13, 2026
8bb49c3
Convert [20-30] to scheduled search instead of removing it
Copilot Jul 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
107 changes: 0 additions & 107 deletions .github/policies/20-issue-label-reminder.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,112 +86,5 @@ configuration:
then:
- removeLabel:
label: missing-required-type
- description: '[20-30] Remind NuGet Client member (issue author) to add Type label'

@nkolev92 nkolev92 Jul 13, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot You were supposed toc hange this to a scheduled search.

Copilot AI Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. [20-30] is now a daily scheduled search (scheduledSearches) with the same Type-label guards and the @${issueAuthor} mention. The isNotLabeledWith: missing-required-type guard ensures it only fires once per issue (same dedup mechanism as [20-10]).

[20-40] (assignee notification) was omitted — it triggered on Reopened/Assigned/Closed events where ${assignees} has meaningful context, but as a scheduled search there is no equivalent filter to target only assigned issues or to avoid pinging empty assignee lists daily.

if:
- payloadType: Issues
- not:
hasLabel:
label: Type:Spec
- not:
hasLabel:
label: Type:Test
- not:
hasLabel:
label: Type:Feature
- not:
hasLabel:
label: Type:Docs
- not:
hasLabel:
label: Type:DCR
- not:
hasLabel:
label: Type:Bug
- not:
hasLabel:
label: Type:DeveloperDocs
- not:
hasLabel:
label: Type:DataAnalysis
- not:
hasLabel:
label: Type:Learning
- not:
hasLabel:
label: Type:Tracking
- not:
hasLabel:
label: Type:Engineering
- not:
hasLabel:
label: Type:BreakingChange
- and:
- isAction:
action: Opened
- activitySenderHasPermission:
permission: Write
- not:
hasLabel:
label: Epic
then:
- addReply:
reply: '@${issueAuthor} Issue is missing Type label, remember to add a [Type label](https://github.com/NuGet/Client.Engineering/blob/main/designs/nuget-issues-approach.md#issue-type)'
- addLabel:
label: missing-required-type
- description: '[20-40] Remind NuGet Client member (issue assignee) to add Type label'
if:
- payloadType: Issues
- and:
- not:
hasLabel:
label: Type:Spec
- not:
hasLabel:
label: Type:Test
- not:
hasLabel:
label: Type:Feature
- not:
hasLabel:
label: Type:Docs
- not:
hasLabel:
label: Type:DCR
- not:
hasLabel:
label: Type:Bug
- not:
hasLabel:
label: Type:DeveloperDocs
- not:
hasLabel:
label: Type:DataAnalysis
- not:
hasLabel:
label: Type:Learning
- not:
hasLabel:
label: Type:Tracking
- not:
hasLabel:
label: Type:Engineering
- not:
hasLabel:
label: Type:BreakingChange
- or:
- isAction:
action: Reopened
- isAction:
action: Assigned
- isAction:
action: Closed
- not:
hasLabel:
label: Epic
then:
- addReply:
reply: ${assignees} Issue is missing Type label, remember to add a [Type label](https://github.com/NuGet/Client.Engineering/blob/main/designs/nuget-issues-approach.md#issue-type)
- addLabel:
label: missing-required-type
onFailure:
onSuccess: