fix(mxc): reject cpu/memory limits instead of silently discarding them - #3548
Open
pkhodade-NV wants to merge 1 commit into
Open
pkhodade-NV wants to merge 1 commit into
pkhodade-NV wants to merge 1 commit into
Conversation
CreateSandbox accepted --cpu/--memory and reached Ready with no Job Object enforcement and no diagnostic, leaving the SDD's T11 host-exhaustion mitigation silently unmet. MXC's schema does not expose CPU rate control or memory limiting outside the WSLC backend, so reject requests carrying cpu/memory limits synchronously at CreateSandbox, matching the existing fail-closed GPU rejection. NVBug 6782894 Signed-off-by: Prashant Khodade <pkhodade@nvidia.com>
pkhodade-NV
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
September 22, 2026 13:37
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CreateSandboxaccepted--cpu/--memoryand reachedReadywith no Job Object enforcement and no diagnostic anywhere (CLI, gateway log, OCSF), leaving the SDD's T11 host-exhaustion mitigation silently unmet.CreateSandbox(andvalidate_sandbox_create) now reject any request carryingcpu_limit,cpu_request,memory_limit, ormemory_requestsynchronously withInvalidArgument, matching the existing fail-closed rejection already used for GPU requests on this driver.crates/openshell-driver-mxc/README.md.Related Issue
NVBug 6782894
Changes
crates/openshell-driver-mxc/src/driver.rs:validate_sandbox_fieldsnow rejects non-empty cpu/memory resource requirements onDriverSandboxTemplate.resources; addedcpu_and_memory_limits_are_rejected_fail_closedregression test.crates/openshell-driver-mxc/README.md: documented the unsupported-resource-limits capability row.Testing
cargo test -p openshell-driver-mxc --lib— 101 passedcargo clippy -p openshell-driver-mxc --tests --target aarch64-pc-windows-msvc -- -D warnings -A dead-code -A unused-imports -A clippy::unused-async— cleancargo build --release -p openshell-gateway -p openshell-cli -p openshell-supervisor-relay(ARM64 host) — buildsopenshell-gateway.exe,openshell.exe,openshell-supervisor-relay.exesuccessfullyChecklist