Conversation
Move control.sock and ssh.sock from the per-sandbox state directory
to /tmp/openshell/sandboxes/{sandbox-id}/ so that socket paths stay
within the 104-byte macOS sun_path limit regardless of the user's
home directory depth.
Closes NVIDIA#3452
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
September 22, 2026 10:19
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move VM driver per-sandbox Unix sockets (
control.sock,ssh.sock) from thestate directory to
/tmp/openshell/sandboxes/{sandbox-id}/so that socket pathsstay within the 104-byte macOS
sun_pathlimit regardless of home directory depth.Related Issue
Closes #3452
Changes
sandbox_socket_dir()helper returning/tmp/openshell/sandboxes/{sandbox-id}(hardcoded
/tmpbecause macOSTMPDIRresolves to ~51-char/var/folders/…/T/which would re-exceed the limit)
/tmp/openshell/sandboxes/created with0o1777(sticky, multi-user safe);per-sandbox dirs remain
0o700control.sockandssh.sockpaths updated to use the new socket directorycreate_sandboxearlyerrors,
provision_sandboxcancellation,fail_provisioning, anddelete_sandboxprovision_sandbox_innerfor the restoration pathTesting
mise run pre-commitpassesChecklist