feat(agent-core-v2): approve unanalyzable bash commands in yolo permission mode - #3869
Merged
sailist merged 1 commit intoSep 17, 2026
Conversation
🦋 Changeset detectedLatest commit: 712cb8b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
N/A — internal change; see Problem below.
Problem
In Ask When Needed (yolo) permission mode, bash commands that cannot be statically analyzed — e.g. commands containing
$VAR, unterminated quotes, or deeply nested shells — still trigger an approval prompt. This interrupts batch flows that the mode is designed to run automatically: users who choose Ask When Needed have already accepted auto-approval of routine commands, and Never Ask mode already skips the guard entirely.What changed
shutdown,rm -rf,ddwriting to devices, ...). Commands that cannot be statically analyzed fall through to the mode's auto-approval.Checklist
/approve).gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.