Skip to content

🐛Bugfix: move health check out of dropdown into inline icon button - #3913

Merged
YehongPan merged 2 commits into
developfrom
zjy/feat3
Sep 15, 2026
Merged

YehongPan merged 2 commits into
developfrom
zjy/feat3

Conversation

@ayiya12

@ayiya12 ayiya12 commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Summary
Move the "Connectivity Check" action out of the More dropdown and surface it as an inline icon button on MCP service cards in the Mine tab.

Changes

  • MineMcpServiceCard.tsx
    • Removed the health-check item from the More dropdown.
    • Added a RefreshCw icon button at the top-right of the card,
image

Copilot AI lite review requested due to automatic review settings September 11, 2026 08:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Non-owned shared services can expose an action that may disable them after a failed health check.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Moves the MCP connectivity check from the More dropdown to an inline button on Mine tab service cards.

Changes:

  • Adds a tooltip-enabled RefreshCw health-check button with loading state.
  • Removes the health-check action from the dropdown.
File summaries
File Summary
frontend/app/[locale]/mcp-space/components/MineMcpServiceCard.tsx Relocates the health-check control; ownership gating must be restored to prevent disabling shared MCP services.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread frontend/app/[locale]/mcp-space/components/MineMcpServiceCard.tsx Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Community cards can display a non-functional health-check button; it should be gated to actionable cards.

Review details

Suppressed comments (1)

frontend/app/[locale]/mcp-space/components/MineMcpServiceCard.tsx:194

  • For kind === "community", isOwned is true, but Mine intentionally filters out community records with sourceMcpId and handleHealthCheck returns when that ID is absent. Every remaining community card therefore renders this button, but clicking it silently does nothing. Gate the button on a local item (or provide a valid MCP id) so only actionable cards display it.
          {onHealthCheck && isOwned ? (
  • Files reviewed: 1/1 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

@YehongPan
YehongPan merged commit 225fd43 into develop Sep 15, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants