Conversation
ayiya12
requested review from
Dallas98,
WMC001 and
jeffwu-1999
as code owners
September 11, 2026 08:44
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Non-owned shared services can expose an action that may disable them after a failed health check.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Moves the MCP connectivity check from the More dropdown to an inline button on Mine tab service cards.
Changes:
- Adds a tooltip-enabled
RefreshCwhealth-check button with loading state. - Removes the health-check action from the dropdown.
File summaries
| File | Summary |
|---|---|
frontend/app/[locale]/mcp-space/components/MineMcpServiceCard.tsx |
Relocates the health-check control; ownership gating must be restored to prevent disabling shared MCP services. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Community cards can display a non-functional health-check button; it should be gated to actionable cards.
Review details
Suppressed comments (1)
frontend/app/[locale]/mcp-space/components/MineMcpServiceCard.tsx:194
- For
kind === "community",isOwnedis true, but Mine intentionally filters out community records withsourceMcpIdandhandleHealthCheckreturns when that ID is absent. Every remaining community card therefore renders this button, but clicking it silently does nothing. Gate the button on a local item (or provide a valid MCP id) so only actionable cards display it.
{onHealthCheck && isOwned ? (
- Files reviewed: 1/1 changed files
- Comments generated: 0 new
- Review effort level: Lite
YehongPan
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move the "Connectivity Check" action out of the
Moredropdown and surface it as an inline icon button on MCP service cards in the Mine tab.Changes
MineMcpServiceCard.tsxhealth-checkitem from theMoredropdown.RefreshCwicon button at the top-right of the card,