Move FakeProvider to eth-json-rpc-provider (as FakeInternalProvider) - #10099
Draft
mcmire wants to merge 1 commit into
Draft
Move FakeProvider to eth-json-rpc-provider (as FakeInternalProvider)#10099mcmire wants to merge 1 commit into
mcmire wants to merge 1 commit into
Conversation
mcmire
force-pushed
the
move-fake-provider-to-eth-json-rpc-provider
branch
from
September 3, 2026 18:53
9605aa6 to
1c19f47
Compare
mcmire
changed the title
mcmire
force-pushed
the
move-fake-provider-to-eth-json-rpc-provider
branch
2 times, most recently
from
September 3, 2026 19:49
f5fb794 to
d016f8a
Compare
`FakeProvider` is a class defined in a top-level test helper file which provides a mock implementation of the `InternalProvider` class in `eth-json-rpc-provider`. Because this file uses types from both `eth-json-rpc-provider` and `network-controller`, these dependencies need to be added to any packages that want to use `FakeProvider` — including `controller-utils`. That creates a strange situation, because `controller-utils` really ought not to depend on anything else. To address this, then, we move `FakeProvider` — now `MockInternalProvider` — into `eth-json-rpc-provider`, and we change all callsites to match. We also remove the dependency on `network-controller`.
mcmire
force-pushed
the
move-fake-provider-to-eth-json-rpc-provider
branch
from
September 3, 2026 21:10
d016f8a to
33756b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
FakeProvideris a class defined in a top-level test helper file which provides a mock implementation of theInternalProviderclass ineth-json-rpc-provider. Because this file uses types from botheth-json-rpc-providerandnetwork-controller, these dependencies need to be added to any packages that want to useFakeProvider— includingcontroller-utils. That creates a strange situation, becausecontroller-utilsreally ought not to depend on anything else.To address this, then, we move
FakeProvider— nowMockInternalProvider— intoeth-json-rpc-provider, and we change all callsites to match. We also remove the dependency onnetwork-controller.References
Checklist