fix: force RPC slow pipeline to update balances - #10058
Open
gabrieledm wants to merge 3 commits into
Open
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ad7c150. Configure here.
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Fixes stale ARC USDC/EURC balances after confirmed swaps by ensuring post-transaction asset refreshes use an authoritative RPC balance pass.
Previously, confirmed transaction refreshes could be skipped on AccountActivity-active chains.
This meant one side of a swap could update while the other remained stale until switching accounts forced a full refresh.
This change:
Tests
Added regression coverage in
AssetsController.test.tsfor:References
Fixes: WPN-1954
Checklist
Note
Medium Risk
Changes balance refresh timing and data-source precedence after confirmations on live chains; incorrect RPC or merge behavior could show wrong balances, but scope is limited to post-confirmation refresh paths with regression tests.
Overview
Fixes stale swap balances (e.g. ARC USDC/EURC) by treating confirmed transaction refreshes differently from pre-confirmation ones.
Confirmed transactions now call
getAssetswithpostTransaction: true. That flag still runs a force refresh on AccountActivity-active chains (only unapproved txs keep skipping those chains), forces the slow pipeline to RPC-only (no Snap), and makes#getSlowPipelineChainIdsrun RPC on all requested chains instead of skipping chains the Accounts API already “covered.” Post-transaction fetches also add graduated ERC-20s from existingassetsBalanceinto the RPCcustomAssetslist so the “receive” side of a swap is queried on-chain.Tests cover the ARC RPC path,
postTransactionontransactionConfirmed, and the split behavior for unapproved vs confirmed on AccountActivity chains. Changelog notes the fix.Reviewed by Cursor Bugbot for commit 64bce4b. Bugbot is set up for automated code reviews on this repo. Configure here.