Skip to content

fix: completion management issue - #10051

Draft
Akaryatrh wants to merge 1 commit into
mainfrom
fix/completion-status-management
Draft

fix: completion management issue#10051
Akaryatrh wants to merge 1 commit into
mainfrom
fix/completion-status-management

Conversation

@Akaryatrh

Copy link
Copy Markdown
Contributor

Explanation

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Signed-off-by: Sébastien Van Eyck <sebastien.vaneyck@consensys.net>
Comment on lines +76 to +77
'TemporarilyDeclined',
'FinallyRejected',

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would these statuses not be sign of an immediate error? Or at least FinallyRejected should?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants