-
Notifications
You must be signed in to change notification settings - Fork 1
docs(cloudflare): fix Worker deploy filename and stale redeploy callout #11222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
7c7138f
docs(cloudflare): fix the Worker deploy recipe's filename and the sta…
MarkusNeusinger cd98b4f
chore(changelog): PR reference on the cloudflare deploy-filename frag…
MarkusNeusinger ea738d0
docs(cloudflare): add the Oxford comma to the hostname list
MarkusNeusinger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| ### Fixed | ||
|
|
||
| - **The Worker deploy recipe now uploads a module Cloudflare can find.** | ||
| `infra/cloudflare/README.md`'s `curl` example named the multipart part | ||
| `worker.js=@infra/cloudflare/anyplot-api-proxy.js;type=application/javascript+module`, | ||
| but curl defaults the part's `filename` to the local file's basename | ||
| (`anyplot-api-proxy.js`) unless told otherwise, and Cloudflare resolves the | ||
| metadata's `main_module: "worker.js"` against that filename, not the form | ||
| field — so the API answered `400 — Uncaught Error: No such module: | ||
| worker.js` (observed live 2026-09-04). The example now sets | ||
| `filename=worker.js` explicitly, with a sentence explaining why. (#11222) | ||
|
|
||
| - **The README's "needs a redeploy" callout is replaced with the deployed | ||
| state.** The Worker was redeployed from the current `.js` after #11221, the | ||
| Transform Rule now covers `anyplot.ai`, `www.anyplot.ai`, and | ||
| `api.anyplot.ai`, and `/api/event` measured `off-seen` — the callout named a | ||
| pending step that had already happened. (#11222) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.