MDEV-39368: Code cleanup and make it more maintainable - #5629
Open
bsrikanth-mariadb wants to merge 1 commit into
Open
bsrikanth-mariadb wants to merge 1 commit into
bsrikanth-mariadb wants to merge 1 commit into
Conversation
bsrikanth-mariadb
commented
Sep 3, 2026
bsrikanth-mariadb
commented
Contributor
- Remove hard codings and instead use MACROS
- Introduce pre and post query hooks
- Remove duplicate code and instead use functions
bsrikanth-mariadb
force-pushed
the
bb-12.3-MDEV-39368-test-replay-code-polish-on-main
branch
from
September 4, 2026 23:36
bd58e36 to
259e421
Compare
bsrikanth-mariadb
force-pushed
the
bb-12.3-MDEV-39368-test-replay-code-polish-on-main
branch
2 times, most recently
from
September 16, 2026 06:59
0133471 to
89963f7
Compare
1. Remove hard codings and instead use MACROS 2. Introduce pre and post query hooks 3. Remove duplicate code and instead use functions
bsrikanth-mariadb
force-pushed
the
bb-12.3-MDEV-39368-test-replay-code-polish-on-main
branch
from
September 16, 2026 07:00
89963f7 to
5016d8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.