chore(ingest): make the EC2 fleet the default so MAPLE_INGEST_FLEETS can go - #967
Merged
Merged
Conversation
…can go prd has run on EC2 alone since the 2026-09-21 cutover. An unset MAPLE_INGEST_FLEETS now means `ec2`, so the variable can be deleted from Infisical; setting it is only for bringing Fargate back beside EC2 or alone. Previews follow the same default, so the `preview:ingest-ec2` label and its workflow plumbing go, and the verify script targets the EC2 service unless the job asked for Fargate alone. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (5)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
`alchemy:destroy:pr` skipped `alchemy:build-deps`, so every PR teardown since the stack started importing `@maple-dev/alchemy/telemetry` died on "Cannot find package" before touching a resource, and closed previews kept their VPC, ALB and hosts. The orphan sweep only covers Cloudflare, so nothing caught it. PR #937's stack was still running an hour after the merge. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…e deploy does Whitespace and comma membership, so a padded or combined value picks the same service the stack actually ran. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prd has run the ingest gateway on the EC2 fleet alone since the 2026-09-21 cutover (#937, then
MAPLE_INGEST_FLEETS=ec2). This makes that the default:parseIngestFleets(undefined)is now{ fargate: false, ec2: true }. The variable is only for bringing Fargate back (fargate,ec2orfargate), so it can be deleted from Infisical prod after this merges.preview:ingest-ec2label and itsMAPLE_INGEST_FLEETSline indeploy-pr-preview.ymlare gone. A preview now exercises the same fleet shape as prd.ingest-preview-verify.shtargets the EC2 service unless the job setMAPLE_INGEST_FLEETS=fargate.Also, found while checking the cutover: every PR preview teardown has been failing since the stack started importing
@maple-dev/alchemy/telemetry.alchemy:destroy:prnever ranalchemy:build-deps, so the destroy died on "Cannot find package" before touching a resource, and closed previews kept their VPC, ALB and hosts. The orphan sweep only covers Cloudflare, so nothing caught it; #937's preview (a c7gd host, an ALB, a VPC) was still running an hour after the merge. The destroy scripts now build deps first, same as deploy.Tests updated; infra typecheck and the root alchemy tsconfig pass.
🤖 Generated with Claude Code
Summary by CodeRabbit