fix(chat-platform): steady tool status line; label the chart's latest value - #1031
Merged
Merged
Conversation
…aw name
Slack and Discord showed the status line as `Tools: `run_sql`…`. Each tool now
has one or more factual phrases ("Running a query…"), picked per call by a hash
of the call id so the phrase varies between calls but holds still across the
edits of one message.
…ol is registered The phrases lived in a table in chat-platform, keyed by tool name and linked to nothing. They are now a required `phrases` option on `McpToolRegistrar.tool`, so a new tool cannot register without them. The session picks one when the call is declared and records it as `label` on the `tool-call` event; the Slack and Discord renderer reads it from there and puts an unlabelled call in words.
…nd name the chart's latest value A finished call dropped its ellipsis, so the status line jumped from "Running a query…" to "Running a query". It now keeps it; a failure appends "(failed)". The single-series chart card showed the last bucket's value bare in the top right, which beside a spike read as a total. It is now labelled "now".
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Note Maple is reviewing this pull request at |
…bels # Conflicts: # apps/ai/src/mcp/tools/pull-request.ts # packages/chat-platform/src/connectors/discord/render.ts # packages/chat-platform/src/connectors/slack/render.test.ts # packages/chat-platform/src/connectors/slack/render.ts
JeremyFunk
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.