Skip to content

feat(i18n): complete Turkish translations - #4277

Merged
KristjanESPERANTO merged 1 commit into
MagicMirrorOrg:developfrom
alkank:feature/improve-turkish-localization
Sep 21, 2026
Merged

KristjanESPERANTO merged 1 commit into
MagicMirrorOrg:developfrom
alkank:feature/improve-turkish-localization

Conversation

@alkank

@alkank alkank commented Sep 20, 2026

Copy link
Copy Markdown

Summary

  • complete and review the core Turkish translation catalog
  • restore the missing relative-day and short-week labels
  • preserve module-name placeholders in update notifications
  • add Turkish translations for the default alert module

Validation

  • Core Turkish catalog matches the 47-key reference catalog.
  • Alert catalog matches the 2-key English source.
  • No missing, extra, empty, or mismatched-placeholder entries.
  • npx prettier translations/tr.json defaultmodules/alert/alert.js defaultmodules/alert/translations/tr.json --check
  • npx eslint defaultmodules/alert/alert.js
  • npx vitest run tests/e2e/translations_spec.js — 138 tests passed.

Test environment note

tests/e2e/modules/alert_spec.js could be started after installing Playwright Chromium, but its two welcome-message scenarios could not find the alert element. The unchanged custom English welcome-message scenario failed in the same way, while the disabled-message scenario passed. The local Node version was 24.14.0; the current dependency metadata requires 24.15.0 or newer.

@KristjanESPERANTO

Copy link
Copy Markdown
Collaborator

@alkank Thanks! But please base your pull requests against the develop branch.

@khassel
khassel force-pushed the feature/improve-turkish-localization branch from 3ff2b30 to 8d368e8 Compare September 20, 2026 20:26
@khassel
khassel changed the base branch from master to develop September 20, 2026 20:26
@khassel
khassel force-pushed the feature/improve-turkish-localization branch from 8d368e8 to 639b73d Compare September 20, 2026 20:28
@khassel

khassel commented Sep 20, 2026

Copy link
Copy Markdown
Collaborator

@KristjanESPERANTO I was able to do the rebase ...

@KristjanESPERANTO

Copy link
Copy Markdown
Collaborator

I checked a few random samples using a translator; it looks good 🙂

@KristjanESPERANTO
KristjanESPERANTO merged commit 34c2e6f into MagicMirrorOrg:develop Sep 21, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants