refactor(newsfeed): replace feedme lib with feedparser - #4269
Merged
Merged
Conversation
rejas
changed the title
rejas
changed the title
Collaborator
|
Nice, this looks good! :) I brought over the tests from my experiments with different parsers and adapted them to your implementation. The existing coverage was a bit thin in this area, and the new tests give us more confidence that the parser switch works as expected. Hope this is okay. |
KristjanESPERANTO
approved these changes
Sep 16, 2026
khassel
approved these changes
Sep 16, 2026
This was referenced Sep 16, 2026
khassel
pushed a commit
that referenced
this pull request
Sep 17, 2026
…4271) While looking closer at newsfeed for #4212, #4267 and #4269, I felt `newsfeedfetcher.js` was doing too much: HTTP/parser stuff, HTML cleanup, and turning raw `feedparser` items into our item format, all in one file. This PR moves the HTML cleanup and item conversion into a new `feeditem.js`. `newsfeedfetcher.js` now only deals with HTTP/parser, feed-level TTL, and config validation for `allowedBasicHtmlTags`. This is just a refactor, no behavior change. Tests were split to match, plus I added one new test for the empty Atom `<summary>` case from #4212.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feedme.js seems to be dead, lets use something more maintained.
Could supersede #4267