test(python): type maintained fixtures for stricter analysis - #351
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3d24c9194b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| remaining = ( | ||
| PYRIGHT_IGNORE.sub("", token.string) if name in TYPE_FIXTURES else token.string | ||
| ) |
There was a problem hiding this comment.
For any path in TYPE_FIXTURES, this strips a rule-scoped Pyright ignore before the forbidden-suppression scan, thereby creating a new blanket quality-policy exception even though this commit adds no corresponding entry to maintainers/quality-exceptions.json. A future # pyright: ignore[...] in any listed fixture will therefore bypass attestation without the required human approval and exact exception record; retain the prohibition until that process is completed.
AGENTS.md reference: AGENTS.md:L6-L9
Useful? React with 👍 / 👎.
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
1 participant
Typed test fixtures replace broad dynamic values at the maintained test boundaries, so stricter Python analysis can inspect facade calls, generated-script exports, refresh payloads, and lock behavior without changing the SDK's runtime or public API. The lock tests use dedicated inspection subclasses instead of reaching into protected methods from unrelated test classes. The policy test also rejects Pyright ignore directives outside intentional-invalid type fixtures.
Validation:
uvx --from uv==0.12.17 uv run --locked poe qualitypasses: Ruff, mypy, basedpyright, 1,964 unit tests, 100% runtime line and branch coverage, generated-client comparison, contract dry run, wheel/sdist and optional-dependency checks, dependency audit, and 501/501 scoped mutants killed.