Skip to content

Support sparse matrices from rocSPARSE - #274

Open
amontoison wants to merge 7 commits into
mainfrom
am/rocsparse
Open

Support sparse matrices from rocSPARSE#274
amontoison wants to merge 7 commits into
mainfrom
am/rocsparse

Conversation

@amontoison

Copy link
Copy Markdown
Collaborator

close #254
Very similar to #253.
Supersede #255

@codecov

codecov Bot commented Nov 1, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 57 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.22%. Comparing base (17bc044) to head (03514b3).

Files with missing lines Patch % Lines
ext/SparseMatrixColoringsAMDGPUExt.jl 0.00% 57 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main     #274      +/-   ##
===========================================
- Coverage   100.00%   97.22%   -2.78%     
===========================================
  Files           19       20       +1     
  Lines         1997     2054      +57     
===========================================
  Hits          1997     1997              
- Misses           0       57      +57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@amontoison

Copy link
Copy Markdown
Collaborator Author

We still have a few issues to fix upstream in AMDGPU.jl: JuliaGPU/AMDGPU.jl#842

Comment thread Project.toml Outdated
Comment thread Project.toml Outdated
@amontoison

Copy link
Copy Markdown
Collaborator Author

Tested locally with an AMD GPU:

julia> include("test/rocm.jl")
Test Summary:                   | Pass  Total   Time
Column coloring & decompression |  216    216  12.1s
  T = ROCSparseMatrixCSC        |  108    108  10.7s
  T = ROCSparseMatrixCSR        |  108    108   1.4s
Test Summary:                | Pass  Total  Time
Row coloring & decompression |  216    216  3.5s
  T = ROCSparseMatrixCSC     |  108    108  2.2s
  T = ROCSparseMatrixCSR     |  108    108  1.3s
Test Summary:                             | Pass  Total  Time
Symmetric coloring & direct decompression |  110    110  5.2s
  T = ROCSparseMatrixCSC                  |   55     55  3.6s
  T = ROCSparseMatrixCSR                  |   55     55  1.6s

@amontoison
amontoison requested a review from gdalle September 6, 2026 03:52
Comment thread Project.toml Outdated
@amontoison

amontoison commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator Author

I tested different versions of AMDGPU.jl and it works with AMDGPU.jl >= v2.2.0.

@gdalle

gdalle commented Sep 7, 2026

Copy link
Copy Markdown
Member

Now that we have access to the JuliaGPU Buildkite machinery, we can just add tests on AMD hardware to CI?

@amontoison

Copy link
Copy Markdown
Collaborator Author

Yes we can do that but JuliaGPU has very limited hardware for AMD. They only have 2 gaming cards for all the ecosystem.
It may takes day before it reaches us in the queue.

@codecov

codecov Bot commented Sep 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 57 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.64%. Comparing base (3ab25db) to head (04698f9).

Files with missing lines Patch % Lines
ext/SparseMatrixColoringsAMDGPUExt.jl 0.00% 57 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #274      +/-   ##
==========================================
- Coverage   99.20%   96.64%   -2.57%     
==========================================
  Files          21       22       +1     
  Lines        2150     2207      +57     
==========================================
  Hits         2133     2133              
- Misses         17       74      +57     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gdalle

gdalle commented Sep 7, 2026

Copy link
Copy Markdown
Member

Let's at least add the option to run it, and maybe control it with a label on the PR, so that we don't run it on every push but we can still automatically check when big changes come up (or changes specifically in the AMD extension)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support rocSPARSE matrices

2 participants