Support sparse matrices from rocSPARSE - #274
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #274 +/- ##
===========================================
- Coverage 100.00% 97.22% -2.78%
===========================================
Files 19 20 +1
Lines 1997 2054 +57
===========================================
Hits 1997 1997
- Misses 0 57 +57 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
We still have a few issues to fix upstream in |
|
Tested locally with an AMD GPU: julia> include("test/rocm.jl")
Test Summary: | Pass Total Time
Column coloring & decompression | 216 216 12.1s
T = ROCSparseMatrixCSC | 108 108 10.7s
T = ROCSparseMatrixCSR | 108 108 1.4s
Test Summary: | Pass Total Time
Row coloring & decompression | 216 216 3.5s
T = ROCSparseMatrixCSC | 108 108 2.2s
T = ROCSparseMatrixCSR | 108 108 1.3s
Test Summary: | Pass Total Time
Symmetric coloring & direct decompression | 110 110 5.2s
T = ROCSparseMatrixCSC | 55 55 3.6s
T = ROCSparseMatrixCSR | 55 55 1.6s |
|
I tested different versions of |
|
Now that we have access to the JuliaGPU Buildkite machinery, we can just add tests on AMD hardware to CI? |
|
Yes we can do that but JuliaGPU has very limited hardware for AMD. They only have 2 gaming cards for all the ecosystem. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #274 +/- ##
==========================================
- Coverage 99.20% 96.64% -2.57%
==========================================
Files 21 22 +1
Lines 2150 2207 +57
==========================================
Hits 2133 2133
- Misses 17 74 +57 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Let's at least add the option to run it, and maybe control it with a label on the PR, so that we don't run it on every push but we can still automatically check when big changes come up (or changes specifically in the AMD extension)? |
close #254
Very similar to #253.
Supersede #255