Skip to content

changed: clearer notation for intermadiate stage vector (k -> ) - #440

Merged
franckgaga merged 1 commit into
mainfrom
oc_notation_k
Sep 4, 2026
Merged

changed: clearer notation for intermadiate stage vector (k -> )#440
franckgaga merged 1 commit into
mainfrom
oc_notation_k

Conversation

@franckgaga

@franckgaga franckgaga commented Sep 3, 2026

Copy link
Copy Markdown
Member

The intermediate stage vector is renamed from $\mathbf{k}$ to $\mathbf{\bar{k}}$ (and nk field to nk̄). This is clearer since $\mathbf{k}_i$ represent one single stage. For example there are 4 stages in RK4, and also one additional stage to support supersample argument, so the $\mathbf{\bar{k}}$ vector include all the intermediates stages, that is nx*(4+1) elements. It applies to both DiffSolver vectors (input of f! function), for ShootingMethods, and to all the CollocationMethods. The number of elements is similar for collocation methods, and this is now explicitly described in the OrthogonalCollocation docstring:

image image

@franckgaga franckgaga changed the title changed: clearer notation for intermadiate stage vector k changed: clearer notation for intermadiate stage vector (k -> ) Sep 3, 2026
@codecov-commenter

codecov-commenter commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.17%. Comparing base (fd5eaaf) to head (4275fa7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #440   +/-   ##
=======================================
  Coverage   97.17%   97.17%           
=======================================
  Files          27       27           
  Lines        6270     6270           
=======================================
  Hits         6093     6093           
  Misses        177      177           
Flag Coverage Δ
unittests 97.17% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@franckgaga
franckgaga merged commit 45dc7cc into main Sep 4, 2026
18 checks passed
@franckgaga
franckgaga deleted the oc_notation_k branch September 4, 2026 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants