Support opt-in legacy MySQL GROUP BY ordering - #2595
Merged
manticore-projects merged 2 commits intoSep 11, 2026
Conversation
Preserve ASC/DESC by grouping-list position and share AST/deparser rendering. Keep existing expression traversal and make appending grouping expressions preserve both the expression list and its directions. Fixes JSQLParser#1169.
Contributor
|
The MySQL folks will be happy! Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MySQL versions before 8.0.13 allow explicit
ASC/DESConGROUP BYitems. Parse and preserve this syntax only when callers selectDialect.MYSQLand opt in withwithLegacyMySqlGroupBy(true); default and other-dialect parsing keep rejecting it.Keep the existing grouping expression list and expose directions by list position, so visitors still see the original expressions. Share clause rendering between
GroupByElementandGroupByDeParser, preserve directions when appending items, and validate ordering with a separateselectGroupByOrderingfeature. Document the option and AST contract.Validation: full Gradle
checkand Mavenverify; regression tests cover dialect/option isolation, mixed explicit and omitted directions, round trips, custom expression deparsing, column traversal, mutable AST operations, and malformed input.Integration validation: all twelve existing PRs plus these three independent fixes pass full Gradle
checktogether (6,495 tests; 0 failures/errors; 25 skipped). Existing dialect-enum, shared-index-helper and documentation conflicts were resolved only in the local validation branch.Fixes #1169.
Syntax reference: https://dev.mysql.com/doc/refman/8.0/en/select.html (the extension was removed in 8.0.13).