Align empty input handling for statement parsing - #2594
Merged
manticore-projects merged 1 commit intoSep 11, 2026
Conversation
Reject null and empty single-statement input with JSQLParserException and return independent empty statement lists from all String overloads. Add regression coverage and document the behavior change. Fixes JSQLParser#2576.
Contributor
|
Thank you for this fine tuning! Good job! |
This was referenced Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Null and empty strings currently return
nullfrom the StringparseandparseStatementsoverloads, even though blank and comment-only input already follows the single-statement versus statement-list contract. Makeparse("")andparse((String) null)throwJSQLParserException, and makeparseStatementsreturn a fresh, mutable emptyStatementslist for either input.Share single-statement input validation and remove the redundant guard in the default statement-list overload. Apply the contract to the configuration-callback and caller-executor overloads, preserving executor ownership. Document the intentional change from the previous null returns.
Regression coverage includes null, empty, blank and comment-only input with complex parsing enabled/disabled, Reader/InputStream consistency, caller-executor reuse after parsing, and independent mutable empty results.
Validation:
check, including formatting, static analysis and coverage: passed.clean verify: passed.Fixes #2576.