Split PostgreSQL hash operators from adjacent identifiers - #2588
Merged
manticore-projects merged 1 commit intoSep 11, 2026
Merged
Conversation
minleejae
force-pushed
the
fix/postgres-json-operator-boundaries
branch
from
September 11, 2026 15:49
d6f0064 to
7e61585
Compare
minleejae
force-pushed
the
fix/postgres-json-operator-boundaries
branch
from
September 11, 2026 15:54
7e61585 to
debad69
Compare
Contributor
|
Thank you much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
Dialect.POSTGRESQL,js#>>'{a,b,1}' <> 'bar'now has the same JSON-expression AST and precedence as the spaced form. Split unquoted identifiers at#, then let the existing lexer recognize#>,#>>or the standalone hash operator. Quoted identifiers and literal bodies retain their contents; default/SQL Server names and MySQL hash comments retain their behavior.Share identifier truncation with hash-comment handling and update token end positions after rewinding. Regression tests cover spacing variants, qualified/quoted names, chained JSON operators, token offsets, statement boundaries and dialect isolation. Full Gradle check and Maven verify passed, using upstream base
eddb1fb5for the local formatter ratchet.Fixes #2163 (the remaining unspaced variant described in the comments; the original spaced query already works).
Reference: PostgreSQL identifier and operator rules.