Support dialect-specific CREATE INDEX definitions - #2586
Merged
manticore-projects merged 1 commit intoSep 11, 2026
Merged
Conversation
Contributor
|
thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CREATE INDEXrejects Spanner'sUNIQUE NULL_FILTEREDcombination, SQL Server'sUNIQUE NONCLUSTEREDcombination, and the schema-qualified PostgreSQL collation/operator-class example in #1994. This change parses and preserves these definitions with an explicit dialect:SPANNER: keep uniqueness inIndex.getType()and null filtering inCreateIndex.isNullFiltered().SQLSERVER: reuseIndex.getClustering()independently of uniqueness.POSTGRESQL: accept qualified collation/operator-class names and bare function keys. Store key attributes once in their structured fields so AST edits are reflected in SQL output.Share key/option expression rendering between the AST and deparser, and route
CREATE INDEXthrough the common definition traversal used by visitors, table discovery and validation. Preserve the default parser's single-type and raw key-parameter behavior, including MySQL prefix lengths.Fixes #652. Addresses the index example in #1994 and the
CREATE UNIQUE NONCLUSTERED INDEXfailure in #1563. This does not resolve all failures in the Sakila scripts linked from #1563. A regression test also covers a PostgreSQL function followed by an index and another statement.Validation:
check: 6,272 tests, no failures, 25 skipped; formatting and static checks passed. The local formatter ratchet uses the upstream base commit because the fork'sorigin/masteris behind upstream.verifypassed.Syntax references: Spanner, SQL Server, PostgreSQL.