Support CockroachDB ALTER PRIMARY KEY with structured hash options - #2585
Merged
manticore-projects merged 4 commits intoSep 11, 2026
Merged
Conversation
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
parser.withDialect(Dialect.COCKROACHDB),ALTER TABLE ... ALTER PRIMARY KEY USING COLUMNS (...)now parses into a dedicatedAlterExpressionPrimaryKeyaction. It preserves key ordering, expression keys, optionalUSING HASH, legacyWITH BUCKET_COUNT = ..., and parenthesized storage parameters such asWITH (bucket_count = 8).Reuse structured
Index.ColumnParamsandIndex.Optionvalues, share action rendering between the AST and AlterDeParser, and centralize ALTER definition traversal for StatementVisitorAdapter and TablesNamesFinder. Hash and storage expressions participate in custom expression visitors. The new production requires the CockroachDB dialect; existing ALTER forms keep their behavior.Validation: the original issue reproducer, optional sharding/storage syntax, AST round-trips and mutation, expression traversal and rewriting, statement/action boundaries, malformed input, and isolation from other dialects; full Gradle check and Maven verify.
Syntax reference: CockroachDB SQL grammar (
alter_table_cmd,index_elem, andopt_hash_sharded).Fixes #1743.