Support Doris distribution hints and share JOIN rendering - #2584
Merged
manticore-projects merged 3 commits intoSep 11, 2026
Conversation
Contributor
|
Thank you much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
parser.withDialect(Dialect.DORIS), queries such asSELECT * FROM a LEFT JOIN [shuffle] b ON a.id = b.idnow parse with a structured JoinHint. Both[shuffle]and[broadcast]are supported, preserving the hint keyword and AFTER_JOIN position.Keep existing SQL Server hints at BEFORE_JOIN and preserve their constructor behavior. Join and SelectDeParser now share the JOIN/APPLY/STRAIGHT_JOIN keyword, hint and FETCH rendering. The new grammar is dialect-gated and introduces no reserved words, so SQL Server bracket-quoted table names retain their interpretation.
Validation: the complete issue reproducer, join variants, AST round-trips and mutation, table discovery, dialect isolation, existing SQL Server hints and quoted identifiers, and malformed hints; full Gradle check and Maven verify.
Syntax reference: Doris distribution hints.
Fixes #1620.