Support SQL Server clustering on primary key and unique constraints - #2582
Merged
manticore-projects merged 1 commit intoSep 11, 2026
Merged
Conversation
Contributor
|
Good, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PRIMARY KEY NONCLUSTERED (actor_id)currently storesNONCLUSTEREDas an index name. Withparser.withDialect(Dialect.SQLSERVER), primary key and unique table constraints now exposeIndex.Clustering.CLUSTERED/NONCLUSTERED, including named and unnamed constraints in CREATE TABLE and ALTER TABLE.A shared grammar production reads the modifier, and Index/NamedConstraint share its rendering. An omitted modifier stays null; other dialects retain their existing identifier interpretation. The dialect requirement is documented.
Validation: the original Sakila example, CREATE/ALTER and named/unnamed variants, AST mutation and round-trips, quoted identifiers, other dialects, and malformed modifiers; full Gradle check and Maven verify.
Fixes #1589.