Fix DISTINCT traversal and share optional select-item visits - #2577
Merged
manticore-projects merged 2 commits intoSep 11, 2026
Conversation
Contributor
|
Thank you for fixing this so fast! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SELECT DISTINCT id FROM foothrows a NullPointerException when visited or classified withgetFeatures(), because ordinary DISTINCT has no ON list.Share the null-safe select-item traversal used by DISTINCT ON, the SELECT list and OUTPUT. Preserve callback order and context, and leave the AST unchanged so ordinary DISTINCT cannot become DISTINCT ON ().
Validation: full Gradle
checkand Mavenverify; plain, nested and CTE DISTINCT, DISTINCT ON/ALL controls, feature classification, model/deparser output, and custom SELECT/OUTPUT callbacks.Fixes #2573.