Skip to content

Update implementation of dpnp.putmask - #3014

Open
vlad-perevezentsev wants to merge 31 commits into
masterfrom
add_putmask_impl
Open

Update implementation of dpnp.putmask#3014
vlad-perevezentsev wants to merge 31 commits into
masterfrom
add_putmask_impl

Conversation

@vlad-perevezentsev

@vlad-perevezentsev vlad-perevezentsev commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

This PR proposes a new implementation of dpnp.putmask replacing the legacy dpnp_putmask implementation with dedicated SYCL kernels : a vectorized contiguous kernel and a strided kernel for F-contiguous/transposed arrays.
It also fully reworks the putmask tests by adding TestPutMask

Performance results on PVC are below:

image
  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@vlad-perevezentsev vlad-perevezentsev self-assigned this Aug 6, 2026
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/pull/3014/index.html

@vlad-perevezentsev
vlad-perevezentsev marked this pull request as ready for review August 7, 2026 12:25
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Array API standard conformance tests for dpnp=0.21.0dev8=py314ha0e2e8e_36 ran successfully.
Passed: 1376
Failed: 0
Skipped: 6

@coveralls

coveralls commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Coverage Status

coverage: 78.548% (+0.06%) from 78.492% — add_putmask_impl into master

@antonwolfy antonwolfy added this to the 0.21.0 release milestone Aug 19, 2026
Comment thread dpnp/backend/extensions/indexing/CMakeLists.txt Outdated
Comment thread dpnp/dpnp_iface_indexing.py Outdated
Comment thread dpnp/backend/extensions/indexing/indexing_py.cpp Outdated
Comment thread dpnp/dpnp_iface_indexing.py Outdated
Comment thread dpnp/dpnp_iface_indexing.py Outdated
Comment thread dpnp/tests/third_party/cupy/indexing_tests/test_insert.py Outdated
Comment thread dpnp/backend/extensions/indexing/putmask.cpp
Comment thread dpnp/backend/kernels/indexing/putmask.hpp Outdated
Comment thread dpnp/backend/kernels/indexing/putmask.hpp Outdated
Comment thread dpnp/backend/kernels/indexing/putmask.hpp Outdated
@antonwolfy antonwolfy mentioned this pull request Aug 21, 2026
7 tasks
Comment thread dpnp/backend/kernels/indexing/putmask.hpp Outdated
Comment thread dpnp/dpnp_iface_indexing.py Outdated
Comment thread dpnp/tests/test_indexing.py
Comment thread dpnp/tests/test_indexing.py
Comment thread dpnp/tests/test_indexing.py
Comment thread dpnp/dpnp_iface_indexing.py Outdated
Comment thread dpnp/backend/extensions/indexing/putmask.cpp
Comment thread dpnp/backend/extensions/indexing/putmask.cpp
Comment thread dpnp/backend/extensions/indexing/putmask.cpp Outdated
Comment thread dpnp/backend/extensions/indexing/putmask.cpp Outdated
Comment thread dpnp/backend/extensions/indexing/putmask.cpp Outdated
Comment thread dpnp/backend/extensions/indexing/putmask.cpp
Comment thread dpnp/backend/extensions/indexing/putmask.cpp Outdated
Comment thread dpnp/backend/extensions/indexing/putmask.cpp Outdated
Comment thread dpnp/tests/test_indexing.py
Comment thread dpnp/backend/extensions/indexing/putmask.cpp
Comment thread dpnp/tests/test_sycl_queue.py Outdated
Comment thread dpnp/dpnp_iface_indexing.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants