Skip to content

feat(pam): snowflake account - #394

Open
lb-vn wants to merge 6 commits into
mainfrom
PAM-426
Open

feat(pam): snowflake account#394
lb-vn wants to merge 6 commits into
mainfrom
PAM-426

Conversation

@lb-vn

@lb-vn lb-vn commented Sep 8, 2026

Copy link
Copy Markdown
Member

Description 📣

New Snowflake account type for PAM with 3 auth methods. Supports web access and CLI access (proxy).

Type ✨

  • Bug fix
  • New feature
  • Improvement
  • Breaking change
  • Documentation

Tests 🛠️

# Here's some code block to paste some code snippets

@linear

linear Bot commented Sep 8, 2026

Copy link
Copy Markdown

PAM-426

Comment thread packages/pam/handlers/snowflake/rest.go Outdated
Comment thread packages/pam/handlers/snowflake/proxy.go
Comment thread packages/pam/handlers/snowflake/proxy.go
@veria-ai

veria-ai Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

PR overview

This pull request adds Snowflake account support to PAM, including REST-based password authentication and session token handling.

Five security issues have been addressed, with one remaining concern in password-authenticated sessions. The session token acts as an offline password verifier, allowing a PAM user to test guesses and potentially recover a weak Snowflake password for direct access outside the recorded session.

Open issues (1)

Fixed/addressed: 5 · PR risk: 4/10

@greptile-apps

greptile-apps Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 0/5

The PR is not safe to merge until credential-bearing Snowflake destinations are constrained and request and response decompression are bounded.

Findings

  1. P1 Security Account Enables Request Redirection
  2. P1 Security Decompressed Requests Are Unbounded
  3. P1 Security Result Responses Are Unbounded
  4. P2 JDBC Parameters Are Unescaped

Summary

  • Adds Snowflake login, query polling, cancellation, token renewal, result translation, and logout behavior.
  • Integrates Snowflake credentials and resource routing throughout PAM and gateway connection tests.
  • Adds focused proxy, authentication, cancellation, parsing, and uploader tests.
  • Introduces blocking outbound-request and memory-exhaustion risks that should be addressed before merge.

Comment thread packages/pam/handlers/snowflake/upstream.go
Comment thread packages/pam/handlers/snowflake/rest.go
Comment thread packages/pam/handlers/snowflake/upstream.go Outdated
Comment thread packages/pam/local/snowflake-proxy.go
Comment thread packages/pam/handlers/snowflake/rest.go Outdated
Comment thread go.mod Outdated
Comment thread packages/gateway-v2/test_connection_handler.go
Comment thread packages/pam/handlers/snowflake/proxy.go Outdated
Comment thread packages/pam/handlers/snowflake/upstream.go
Comment thread packages/pam/handlers/snowflake/upstream.go Outdated
Comment thread packages/pam/handlers/snowflake/proxy.go
Comment thread packages/pam/handlers/snowflake/proxy.go
Comment thread packages/pam/handlers/snowflake/rest.go Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants