Skip to content

feat(storage): add sample for hierarchical namespace recursive delete - #4434

Merged
amcolin merged 8 commits into
mainfrom
feat/add-node-delete-folder-recursive
Sep 9, 2026
Merged

amcolin merged 8 commits into
mainfrom
feat/add-node-delete-folder-recursive

Conversation

@nidhiii-27

Copy link
Copy Markdown
Contributor

Draft PR for hierarchical namespace recursive delete folder sample.

[Generated-by: AI]

Adds a Node.js code sample demonstrating hierarchical namespace recursive folder delete.

Fixes: b/530059535

[Generated-by: AI]
Add helpful log statements.
…ests

Re-enable recursive delete folder integration tests and resolve GCS billing project limitations.

[Generated-by: AI]
Remove skip comment for 'should delete a folder recursively' integration test.

[Generated-by: AI]
@product-auto-label product-auto-label Bot added api: storage Issues related to the Cloud Storage API. samples Issues that are directly related to samples. labels Aug 29, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new sample script deleteFolderRecursive.js to recursively delete folders, updates renameFolder.js to strip billing project headers, bumps the @google-cloud/storage-control dependency, and updates system tests to explicitly pass the project ID to the Storage client. It also enables the folder renaming test and adds a test for recursive deletion. Regarding the feedback, there is an issue in deleteFolderRecursive.js where a failed operation is incorrectly logged as successful; the code should check for op.error and throw an error if the operation fails.

Comment thread storage-control/deleteFolderRecursive.js
@nidhiii-27
nidhiii-27 marked this pull request as ready for review August 31, 2026 05:51
@nidhiii-27
nidhiii-27 requested review from a team as code owners August 31, 2026 05:51
@snippet-bot

snippet-bot Bot commented Aug 31, 2026

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@angelcaamal angelcaamal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks solid to me.

@amcolin
amcolin merged commit 2a254e7 into main Sep 9, 2026
22 checks passed
@amcolin
amcolin deleted the feat/add-node-delete-folder-recursive branch September 9, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants