fix(ci): run the suite before tagging a release - #162
Merged
Merged
Conversation
The release job tagged, released and published on every push to main with no test gate in front of it, and its pending-release lookup filtered the label client-side over one page of closed PRs, so a release past that page read as nothing to release and passed silently. Splits the matrix into a reusable run_tests.yml that both ci.yml and the release flow call, and brings release.yml to the detect/tests/release shape the other five SDKs use.
mogita
commented
Sep 15, 2026
mogita
left a comment
Contributor
Author
There was a problem hiding this comment.
Two substantial findings, inline.
The workflow concurrency group already covers it: a push during a release run goes pending rather than running, and starts only once the tag exists and the label has flipped, so its own detect reports no pending release and release-pr runs.
mogita
had a problem deploying
to
feeds-enabled-shard
September 15, 2026 15:23 — with
GitHub Actions
Failure
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
CHA-2963
Problem
The release job tags, creates the GitHub Release and publishes on every push to
mainwith no test gate in front of it, so a red suite still ships a tag. For Go that is permanent:proxy.golang.orgcaches a tag forever.Its pending-release lookup also reads one page of closed PRs and filters the label client-side, then takes
.[0]. A release that has slipped past that page reads as "nothing to release", and the job exits 0 without tagging.Solution
run_tests.yml: the test-and-build matrix, moved out ofci.ymlunchanged (the job body is byte-identical) and exposed asworkflow_call.ci.yml: calls it onpull_request. Thepush: maintrigger is dropped, because otherwise a release push would run the integration leg twice at once against the sharedd2sj6pudbhz7app, which is what made php and net flake.release.yml:detectfinds the pending release and verifies thego.modmajor,testsruns the suite,releasetags only after both. The label query now filters server-side and by base branch, matching the other five SDKs.Workflow-level
permissionsdrops tocontents: read, with per-job grants.How to verify
ci / 👷 Test & Build …and are the same six that ran before.ReleaserunsDetect pending release→Tests→🚀 Tag and release. A failing suite leaves the tag uncreated.detectprints "No pending release" and onlyRelease PRruns.Review instructions
Run the branch-protection PATCH before merging, not after. A reusable-workflow call reports as
<caller job id> / <called job name>, and the six required contexts are currently the bare names, so this PR's own checks already report under the new names and itsmergeable_stateisblockeduntil the contexts move. Sendingchecksrather thancontexts[]keeps theapp_id: 15368pinning the branch has today:Every other open PR here stalls until it is rebased. #161, #127, #126, #105, #104, #73, #68 and #59 all run the old
ci.ymlon their heads, so they report the bare names and block on the new ones.strict=truealready requires those rebases, but this turns a per-PR rebase into a fleet-wide one.One trade-off worth knowing: with
push: maingone, Codecov stops getting a report on every main commit and gets one per release commit instead. PR coverage still uploads on every run.