1.21.11 compat - #2306
Closed
The-Hypnos wants to merge 6 commits into
Closed
1.21.11 compat#2306The-Hypnos wants to merge 6 commits into
The-Hypnos wants to merge 6 commits into
Conversation
setFlag() legitimately returns null when a StateFlag is parsed from "none" (clearing the flag), but the caller unconditionally called .toString() on the result. Fixes EngineHub#2305
event.getBlock() can throw when its underlying Location's world no longer resolves, on some platforms. Guard both listeners against it instead of letting it spam the console. Fixes EngineHub#2238
Calendar.MONTH is 0-indexed (January = 0); the %m log path token needs it 1-indexed. Fixes EngineHub#1280
RemoveCause.PHYSICS (e.g. a boat colliding with the hanging entity) wasn't handled at all - only EXPLOSION was - so entity-item-frame-destroy, entity-painting-destroy, and their global config equivalents never applied to that removal path. Fixes EngineHub#1434
Canvas doesn't fire the vanilla PlayerTeleportEvent for entity-driven teleports (confirmed via Canvas's own docs and live testing - zero event delivery for any teleport cause on this platform), so the ENDERPEARL/CHORUS_TELEPORT flags were silently unenforced. Add a listener for Canvas's own EntityTeleportAsyncEvent instead, only registered when that class is actually present at runtime, so it has no effect on non-Canvas platforms. Fixes EngineHub#2302
Both are consumed from the player's inventory before the teleport event fires (on throw / on eating respectively), so denying the teleport was leaving the player down an item for nothing. Skipped in creative mode, matching the existing pattern for XP bottles in EventAbstractionListener#onExpBottle.
Author
|
accident didn't mean to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.