Recognize ObjcCompile as a compile action in the Bazel extractor - #22
Open
svelezsaffon wants to merge 1 commit into
Open
svelezsaffon wants to merge 1 commit into
svelezsaffon wants to merge 1 commit into
Conversation
Why: extract_bazel.py decides which bazel aquery actions count as "a compile" with a set _COMPILE, ObjcCompile wasn't in that set, extract_bazel.py silently dropped every Objective-C compile action when building model.bazel.json. On CMake's side, the File API reports .m The result: the differ saw sources that CMake compiled and Bazel appeared not to, and reported them as missing_tu errors a false signal. The files were compiling fine (bazel build succeeds); the extractor just couldn't see the actions. Verification: - Full test suite passes (127 tests, up from 126). - Re-ran against a real captured raylib migration (//:glfw, //:glfw_cocoa, //:raylib): regenerating aquery.json with ObjcCompile added to the mnemonic filter and re-running the extractor/differ eliminates all 5 missing_tu false positives. The 5 .m files now correctly participate in the diff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
extract_bazel.py decides which bazel aquery actions count as "a compile" with a set defined in _COMPILE, ObjcCompile wasn't in that set, extract_bazel.py silently dropped every Objective-C compile action when building model.bazel.json. On CMake's side, the File API reports .m
The result:
The differ saw sources that CMake compiled and Bazel appeared not to, and reported them as missing_tu errors. The files were compiling fine (bazel build succeeds); the extractor just couldn't see the actions.
Verification: