make sure that necessary quotes are retained for --fusemount "..." option in output produced by eessi_container.sh - #304
Merged
Conversation
…tion in output produced by eessi_container.sh
bedroge
approved these changes
Sep 11, 2026
Micket
reviewed
Sep 11, 2026
| BIND_PATHS="${BIND_PATHS},/cvmfs/cvmfs-config.cern.ch" | ||
| else | ||
| EESSI_FUSE_MOUNTS+=("--fusemount" "container:cvmfs2 cvmfs-config.cern.ch /cvmfs/cvmfs-config.cern.ch") | ||
| EESSI_FUSE_MOUNTS+=("--fusemount" '"container:cvmfs2 cvmfs-config.cern.ch /cvmfs/cvmfs-config.cern.ch"') |
There was a problem hiding this comment.
Suggested change
| EESSI_FUSE_MOUNTS+=("--fusemount" '"container:cvmfs2 cvmfs-config.cern.ch /cvmfs/cvmfs-config.cern.ch"') | |
| EESSI_FUSE_MOUNTS+=("--fusemount" "\"container:cvmfs2 cvmfs-config.cern.ch /cvmfs/cvmfs-config.cern.ch\"") |
For consistency?
Contributor
Author
There was a problem hiding this comment.
Meh, I figured I could avoid escaping the double quotes here, since there's no ${EESSI*} environment variable involved here, I would keep it as is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic tests (+ CI we have for this script) shows it still works as expected, and now shows double quotes for
--fusemountoption in output: