Add USB PID for DroneerX6 - #7
Merged
Merged
Conversation
mrpollo
requested changes
Sep 15, 2026
|
|
||
| - name: Droneer | ||
| px4_vendor: droneer | ||
| contact: noreply@droneer.com |
Contributor
There was a problem hiding this comment.
We need an email we can reach out to, please update.
There was a problem hiding this comment.
🟡 Changes recommended
The board name and contact address do not satisfy the requested registration requirements.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds Droneer’s USB PID assignment for the DroneerX6 board.
Changes:
- Claims block
0x06E0–0x06EF. - Assigns PID
0x06E0. - Adds Droneer manufacturer metadata.
File summaries
| File | Summary |
|---|---|
usb-ids.yaml |
Adds the Droneer registry entry. Two moderate findings remain: use DroneerX6 as the board name and replace the no-reply contact with a monitored address. |
Review details
Suppressed comments (1)
usb-ids.yaml:82
- The
contactfield is the manufacturer address maintainers must use for follow-up, and the PR template requires it to be monitored;noreply@droneer.comexplicitly denotes a no-reply mailbox and does not satisfy that contract. Please replace it with a monitored support/contact address.
contact: noreply@droneer.com
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| blocks: ["0x06E0"] # 0x06E0-0x06EF | ||
| pids: | ||
| - pid: "0x06E0" | ||
| board: X6 |
mrpollo
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manufacturer: Droneer
Board(s): DroneerX6
blocks(first request: claim a free aligned 16-PID block,0x06E0)