Skip to content

remove inlines from react CardView demos - #34942

Merged
DuckTieCorpMember merged 1 commit into
DevExpress:mainfrom
DuckTieCorpMember:react-demos-remove-inlines
Aug 28, 2026
Merged

DuckTieCorpMember merged 1 commit into
DevExpress:mainfrom
DuckTieCorpMember:react-demos-remove-inlines

Conversation

@DuckTieCorpMember

Copy link
Copy Markdown
Contributor

Removed inline objects and functions from React CardView demos:

  1. Colulmn Header Filter
  2. Data Validation
  3. Field Template
  4. Popup Editing
  5. Selection
  6. Web API Service

@DuckTieCorpMember DuckTieCorpMember self-assigned this Aug 27, 2026
Copilot AI lite review requested due to automatic review settings August 27, 2026 05:28
@DuckTieCorpMember
DuckTieCorpMember requested a review from a team as a code owner August 27, 2026 05:28

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request refactors several React CardView demo apps to remove inline object and function literals from JSX props, improving render stability (referential equality) and readability across the demos listed in the PR description.

Changes:

  • Extracted inline configuration objects (e.g., popup, editorOptions, searchExpr) into module-level constants.
  • Extracted inline template/render callbacks into named functions/constants to avoid recreating functions on each render.
  • Introduced small derived booleans/constants in the Selection demos to replace repeated inline expressions.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
apps/demos/Demos/CardView/WebAPIService/ReactJs/App.js Extracts popup and select-box editorOptions into constants.
apps/demos/Demos/CardView/WebAPIService/React/App.tsx Same as above for the TypeScript React demo.
apps/demos/Demos/CardView/Selection/ReactJs/App.js Extracts mode arrays/default keys and replaces inline conditions with derived booleans.
apps/demos/Demos/CardView/Selection/React/App.tsx Same as above with explicit TypeScript typing for mode arrays.
apps/demos/Demos/CardView/PopupEditing/ReactJs/App.js Moves popup and text-area editorOptions into constants.
apps/demos/Demos/CardView/PopupEditing/React/App.tsx Same as above for the TypeScript React demo.
apps/demos/Demos/CardView/FieldTemplate/ReactJs/App.js Extracts inline render/field template callbacks into named constants.
apps/demos/Demos/CardView/FieldTemplate/React/App.tsx Same as above with typed template callback signatures.
apps/demos/Demos/CardView/DataValidation/ReactJs/App.js Extracts popup and editor option objects (notes/mobile phone) into constants.
apps/demos/Demos/CardView/DataValidation/React/App.tsx Same as above for the TypeScript React demo.
apps/demos/Demos/CardView/ColumnHeaderFilter/ReactJs/App.js Extracts header-filter search editor options and searchExpr arrays into constants.
apps/demos/Demos/CardView/ColumnHeaderFilter/React/App.tsx Same as above for the TypeScript React demo.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@DuckTieCorpMember
DuckTieCorpMember added this pull request to the merge queue Aug 27, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to Branch Protection failures Aug 27, 2026
You're not authorized to push to this branch. Visit "About protected branches" for more information.
@DuckTieCorpMember
DuckTieCorpMember added this pull request to the merge queue Aug 27, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to Branch Protection failures Aug 27, 2026
You're not authorized to push to this branch. Visit "About protected branches" for more information.
@AlisherAmonulloev
AlisherAmonulloev added this pull request to the merge queue Aug 27, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to Branch Protection failures Aug 27, 2026
You're not authorized to push to this branch. Visit "About protected branches" for more information.
@DuckTieCorpMember
DuckTieCorpMember added this pull request to the merge queue Aug 27, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to Branch Protection failures Aug 27, 2026
You're not authorized to push to this branch. Visit "About protected branches" for more information.
@DuckTieCorpMember
DuckTieCorpMember added this pull request to the merge queue Aug 27, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to Branch Protection failures Aug 27, 2026
You're not authorized to push to this branch. Visit "About protected branches" for more information.
Copilot AI review requested due to automatic review settings August 28, 2026 05:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated no new comments.

Copilot AI review requested due to automatic review settings August 28, 2026 12:00
@DuckTieCorpMember
DuckTieCorpMember force-pushed the react-demos-remove-inlines branch from be9886d to b8d585f Compare August 28, 2026 12:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated no new comments.

@DuckTieCorpMember
DuckTieCorpMember added this pull request to the merge queue Aug 28, 2026
Merged via the queue into DevExpress:main with commit 093effd Aug 28, 2026
111 checks passed
@DuckTieCorpMember
DuckTieCorpMember deleted the react-demos-remove-inlines branch August 28, 2026 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants