remove inlines from react CardView demos - #34942
Merged
DuckTieCorpMember merged 1 commit intoAug 28, 2026
Merged
DuckTieCorpMember merged 1 commit into
DuckTieCorpMember merged 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request refactors several React CardView demo apps to remove inline object and function literals from JSX props, improving render stability (referential equality) and readability across the demos listed in the PR description.
Changes:
- Extracted inline configuration objects (e.g.,
popup,editorOptions,searchExpr) into module-level constants. - Extracted inline template/render callbacks into named functions/constants to avoid recreating functions on each render.
- Introduced small derived booleans/constants in the Selection demos to replace repeated inline expressions.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| apps/demos/Demos/CardView/WebAPIService/ReactJs/App.js | Extracts popup and select-box editorOptions into constants. |
| apps/demos/Demos/CardView/WebAPIService/React/App.tsx | Same as above for the TypeScript React demo. |
| apps/demos/Demos/CardView/Selection/ReactJs/App.js | Extracts mode arrays/default keys and replaces inline conditions with derived booleans. |
| apps/demos/Demos/CardView/Selection/React/App.tsx | Same as above with explicit TypeScript typing for mode arrays. |
| apps/demos/Demos/CardView/PopupEditing/ReactJs/App.js | Moves popup and text-area editorOptions into constants. |
| apps/demos/Demos/CardView/PopupEditing/React/App.tsx | Same as above for the TypeScript React demo. |
| apps/demos/Demos/CardView/FieldTemplate/ReactJs/App.js | Extracts inline render/field template callbacks into named constants. |
| apps/demos/Demos/CardView/FieldTemplate/React/App.tsx | Same as above with typed template callback signatures. |
| apps/demos/Demos/CardView/DataValidation/ReactJs/App.js | Extracts popup and editor option objects (notes/mobile phone) into constants. |
| apps/demos/Demos/CardView/DataValidation/React/App.tsx | Same as above for the TypeScript React demo. |
| apps/demos/Demos/CardView/ColumnHeaderFilter/ReactJs/App.js | Extracts header-filter search editor options and searchExpr arrays into constants. |
| apps/demos/Demos/CardView/ColumnHeaderFilter/React/App.tsx | Same as above for the TypeScript React demo. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Tucchhaa
approved these changes
Aug 27, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to Branch Protection failures
Aug 27, 2026
You're not authorized to push to this branch. Visit "About protected branches" for more information.
github-merge-queue
Bot
removed this pull request from the merge queue due to Branch Protection failures
Aug 27, 2026
You're not authorized to push to this branch. Visit "About protected branches" for more information.
github-merge-queue
Bot
removed this pull request from the merge queue due to Branch Protection failures
Aug 27, 2026
You're not authorized to push to this branch. Visit "About protected branches" for more information.
github-merge-queue
Bot
removed this pull request from the merge queue due to Branch Protection failures
Aug 27, 2026
You're not authorized to push to this branch. Visit "About protected branches" for more information.
github-merge-queue
Bot
removed this pull request from the merge queue due to Branch Protection failures
Aug 27, 2026
You're not authorized to push to this branch. Visit "About protected branches" for more information.
DuckTieCorpMember
enabled auto-merge
August 28, 2026 05:41
DuckTieCorpMember
force-pushed
the
react-demos-remove-inlines
branch
from
August 28, 2026 12:00
be9886d to
b8d585f
Compare
DuckTieCorpMember
disabled auto-merge
August 28, 2026 12:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed inline objects and functions from React CardView demos: