Avoid Maven Central fallback when proxy is configured - #12403
Conversation
AlexeyKuznetsov-DD
added
type: bug fix
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bdcc0a7fc8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![datadog-datadog-prod-us1-2[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
There was a problem hiding this comment.
A Gradle property can configure the proxy without the matching environment variable. Gradle then uses the proxy, but Muzzle still uses Maven Central and can select a version that the proxy cannot resolve.
🤖 Datadog Autotest · Commit bdcc0a7 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
|
/merge -f --reason "Skip MQ, since it is a build fix and tested on PR" |
|
View all feedbacks in Devflow UI.
It will be processed automatically as soon as GitHub reports it as mergeable. View in MergeQueue UI.
alexey.kuznetsov@datadoghq.com unqueued this merge request |
|
/code blockers |
|
View all feedbacks in Devflow UI.
Checking merge blockers for #12403...
No merge blockers detected. |
|
/merge -c |
|
View all feedbacks in Devflow UI.
|
|
/merge -f --reason "Skip MQ, since it is a build fix and tested on PR" |
|
View all feedbacks in Devflow UI.
The expected merge time in
Warning This change was merged without running any pre merge CI checks Reason: Skip MQ, since it is a build fix and tested on PR |
c5cda76
into
master
Avoid Maven Central fallback when proxy is configured Co-authored-by: alexey.kuznetsov <alexey.kuznetsov@datadoghq.com>
Avoid Maven Central fallback when proxy is configured Co-authored-by: alexey.kuznetsov <alexey.kuznetsov@datadoghq.com>
2 participants
What Does This Do
This is a temporary workaround for Maven Central rate limiting. The previous Muzzle fallback remains visible in a comment for straightforward restoration, and the test that asserts the fallback is disabled with a corresponding TODO.
When a Maven repository proxy is configured, use it instead of retaining Maven Central as a fallback for project dependency resolution and Muzzle version discovery.
Motivation
Adding the proxy before Maven Central did not isolate CI from Maven Central. Gradle dynamic-version resolution and Muzzle's Aether version-range resolution can inspect every configured repository, so CI continued making direct Maven Central requests and received HTTP 429 responses.
Combining repository metadata also allowed Muzzle to discover a newly published dependency version from Maven Central before it was available through the configured proxy. Muzzle then generated compatibility tasks for a version that the proxy could not resolve. Making version discovery proxy-only keeps the generated task set aligned with the artifacts available to the build.
Additional Notes
Representative failure evidence:
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: N/A