Skip to content

Exclude unused dependencies from WildFly Muzzle checks - #12297

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
masterfrom
alexeyk/fix-wildfly-41-muzzle
Aug 26, 2026
Merged

Exclude unused dependencies from WildFly Muzzle checks#12297
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
masterfrom
alexeyk/fix-wildfly-41-muzzle

Conversation

@AlexeyKuznetsov-DD

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

What Does This Do

Excludes unused io.undertow and org.jboss.remoting dependencies from WildFly Muzzle checks. This removes the temporary exclusion for wildfly-ee:41.0.1.Final, so Muzzle continues to validate that version.

Motivation

WildFly 41.0.1 pulls in jboss-remoting:5.0.32.Final and undertow-core:2.4.3.Final. Both artifacts are published in JBoss Releases but not in Maven Central or Red Hat GA, and Depot currently returns 404 for them. Dependency resolution therefore fails before Muzzle compatibility assertions can run.

The WildFly instrumentation does not reference APIs from either dependency group, so they do not need to be present on the Muzzle analysis classpath.

Additional Notes

This follows the dependency-exclusion approach used in #12243. The exclusions apply only to Muzzle's generated dependency configurations; the WildFly runtime test dependencies remain unchanged.

Contributor Checklist

Jira ticket: N/A

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD added inst: others All other instrumentations type: bug fix Bug fix tag: ai generated Largely based on code generated by an AI or LLM tag: no release notes Changes to exclude from release notes labels Aug 26, 2026
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD self-assigned this Aug 26, 2026
@AlexeyKuznetsov-DD
AlexeyKuznetsov-DD marked this pull request as ready for review August 26, 2026 02:00
@AlexeyKuznetsov-DD
AlexeyKuznetsov-DD requested a review from a team as a code owner August 26, 2026 02:00

@datadog-datadog-prod-us1 datadog-datadog-prod-us1 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

The change skips only WildFly 41.0.1.Final from the existing muzzle range. All other WildFly versions stay in the compatibility checks.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Datadog Autotest · Commit 161bc34 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@datadog-datadog-prod-us1

This comment has been minimized.

@dd-octo-sts

dd-octo-sts Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.95 s 14.66 s [+1.0%; +2.9%] (significantly worse)
startup:insecure-bank:tracing:Agent 13.72 s 13.70 s [-1.0%; +1.3%] (no difference)
startup:petclinic:appsec:Agent 17.55 s 17.38 s [+0.1%; +1.7%] (maybe worse)
startup:petclinic:iast:Agent 17.44 s 17.54 s [-1.3%; +0.1%] (no difference)
startup:petclinic:profiling:Agent 17.49 s 17.41 s [-0.6%; +1.6%] (no difference)
startup:petclinic:sca:Agent 17.20 s 17.38 s [-2.0%; -0.2%] (maybe better)
startup:petclinic:tracing:Agent 16.54 s 16.66 s [-1.7%; +0.4%] (no difference)

Commit: 0b9fb50e · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@bric3 bric3 changed the title Skip WildFly 41.0.1 in muzzle checks Exclude unused dependencies from WildFly Muzzle checks Aug 26, 2026

@amarziali amarziali left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good thanks

@bric3
bric3 added this pull request to the merge queue Aug 26, 2026
@dd-octo-sts

dd-octo-sts Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Aug 26, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-08-26 12:04:23 UTC ℹ️ Start processing command /merge


2026-08-26 12:04:27 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 2h (p90).


2026-08-26 13:16:19 UTC ⚠️ MergeQueue: This merge request build was cancelled

alexey.kuznetsov@datadoghq.com cancelled this merge request build

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 26, 2026
@AlexeyKuznetsov-DD

Copy link
Copy Markdown
Contributor Author

/merge -c

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Aug 26, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-08-26 13:16:10 UTC ℹ️ Start processing command /merge -c

@AlexeyKuznetsov-DD

Copy link
Copy Markdown
Contributor Author

/merge -f --reason "No need to run MQ since we do not test Muzzle as part of MQ"

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Aug 26, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-08-26 13:17:36 UTC ℹ️ Start processing command /merge -f --reason "No need to run MQ since we do not test Muzzle as part of MQ"


2026-08-26 13:17:41 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 0s (p90).


2026-08-26 13:17:50 UTC ℹ️ MergeQueue: This merge request was merged

Warning

This change was merged without running any pre merge CI checks

Reason: No need to run MQ since we do not test Muzzle as part of MQ

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 2782c6c into master Aug 26, 2026
604 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the alexeyk/fix-wildfly-41-muzzle branch August 26, 2026 13:17
@github-actions github-actions Bot added this to the 1.66.0 milestone Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

inst: others All other instrumentations tag: ai generated Largely based on code generated by an AI or LLM tag: no release notes Changes to exclude from release notes type: bug fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants