Add smoke tests documentation - #12282
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e352616c17
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
![datadog-datadog-prod-us1-2[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
There was a problem hiding this comment.
The new module recipe does not work as written. The guide also says that telemetry checks always run, but the code skips them for shared backends and apps without the agent.
🤖 Datadog Autotest · Commit e352616 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
AlexeyKuznetsov-DD
left a comment
AlexeyKuznetsov-DD
left a comment
There was a problem hiding this comment.
Not sure if that was intended, but this PR also has several changed tests, not just documentation as declared in PR description. Maybe base brunch was not correctly specified for this PR?
Not really. AI is increasing scope which means I need to get back at previous PRs… I won't split the doc for the "curent features" and update it later with the latest revisions… So I need to squeeze in new PR in the stack before the doc. That so many hours wasted 😮💨 |
e352616 to
a3dea1d
Compare
|
Everything should be back on track. Thanks for the feedback Alexey 🙏 |
bric3
left a comment
bric3
left a comment
There was a problem hiding this comment.
Content looks good, I added one suggestion / information about how to run a nested build.
Structure-wise I think the section on how to add a smoke test module is not enough visible, level 2 is OK, but there are too many level 2 sections above ; maybe deepening a bit them would be better.
Regardless, these are not blockers, so approving.
a3dea1d to
7213852
Compare
This comment has been minimized.
This comment has been minimized.
|
/merge |
|
View all feedbacks in Devflow UI.
It will be processed automatically as soon as GitHub reports it as mergeable. View in MergeQueue UI.
The expected merge time in
|
3 participants
What Does This Do
This PR introduces documentation for the new smoke test framework.
Motivation
Help with discovery and adoption.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]