Add IDM as co-owners for all instrumentations - #12276
Add IDM as co-owners for all instrumentations#12276gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f835f793e3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
The final build file rules remove the IDM owner from instrumentation build files. Instrumentation version changes can still require a review from the language platform team.
🤖 Datadog Autotest · Commit f835f79 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
|
🎯 Code Coverage (details) 🔗 Commit SHA: 95c19ca | Docs | View more details | Give us feedback! |
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
There was a problem hiding this comment.
The final generic build file rules override the earlier instrumentation rule. Instrumentation build files do not request IDM review, so the main ownership goal is incomplete.
🤖 Datadog Autotest · Commit 4f1d304 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
Build pipeline has failing jobs for c91327b: What to do next?
DetailsSince those jobs are not marked as being allowed to fail, the pipeline will most likely fail. |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
What Does This Do
Add IDM as co-owners for all instrumentations to ease reviewing PRs such as #12266 that update instrumentation versions -- with this change, we should only need one review from an IDM team member instead of reviews from each team with updated instrumentation versions.
Also split all
gradle.lockfiles between IDM (instrumentation-related) and LP (other) for similar reasons.Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]