Bootstrap 5 - #265
Conversation
394ad04 to
6b2606d
Compare
BigSpaceships
left a comment
BigSpaceships
left a comment
There was a problem hiding this comment.
W bootstrap 5, just a few thoughts
Also, can you add theme switching?
| .text-bg-blue { | ||
| color: #fff; | ||
| background-color: #2196f3; | ||
| } | ||
|
|
||
| .text-bg-pink { | ||
| color: #fff; | ||
| background-color: #cb42a9; | ||
| } | ||
|
|
||
| .badge-purple { | ||
| .text-bg-purple { | ||
| color: #fff; | ||
| background-color: #b19cd9; | ||
| } | ||
|
|
||
| .badge-strange { | ||
| .text-bg-green { | ||
| color: #fff; | ||
| background-color: #4caf50; | ||
| } | ||
|
|
||
| .text-bg-strange { |
There was a problem hiding this comment.
I'm pretty sure there's builtin classes for these
https://getbootstrap.com/docs/5.3/utilities/background/
for csh primary is purple secondary is pink
There was a problem hiding this comment.
I'm pretty sure there's builtin classes for these https://getbootstrap.com/docs/5.3/utilities/background/ for csh primary is purple secondary is pink
This is true, but i was trying to keep the same colors as what things are currently. I know for sure that the success and info classes are different shades of green and blue than what is currently used, and we already had those custom classes for pink and purple, which i assume is for the same reason. Im open to trying the existing classes, and I can see how they look tho
|
|
||
| {% if "current_student" in member_info.group_list %} | ||
| <span class="badge badge-pill badge-secondary">Current Student</span> | ||
| <span class="badge rounded-pill text-bg-light">Current Student</span> |
There was a problem hiding this comment.
these are super low contrast
2 participants
What
Update styles to bootstrap 5
Why
Bootstrap 5 is good
Test Plan
Ensure everything works as expected. There should not be any differences in functionality.
Env Vars
No (mostly).
I did fix one issue where, in
config.env.py, the line that would get theLDAP_BIND_PASSwas looking for the variable namedLDAP_BIND_PWin the.env, which didn't match the name used in every other place for that variable. Now running the project locally (in the compose) should work with no issues.Documentation
No updates needed
Checklist