Skip to content

chore: sync vendored Comfy Router spec (cloud@4dc6e93) - #147

Closed
comfy-pr-bot wants to merge 1 commit into
mainfrom
chore/sync-router-spec-4dc6e93
Closed

comfy-pr-bot wants to merge 1 commit into
mainfrom
chore/sync-router-spec-4dc6e93

Conversation

@comfy-pr-bot

@comfy-pr-bot comfy-pr-bot commented Sep 14, 2026

Copy link
Copy Markdown
Member

Automated sync of the public Comfy Router spec,
projected from the canonical contract (internal notes stripped).
Source: cloud@4dc6e93.

It lands at spec/router-openapi.yaml and is a contract of its
own — it is never merged into another vendored spec in this repo.

This PR is on its own per-source-commit branch (chore/sync-router-spec-4dc6e93); a later
spec change opens a separate PR and will not touch this branch, so a
regen commit pushed here is safe.

No Router operations are currently unserved (as of cloud@4dc6e93).

This note auto-refreshes while this PR is open: a change to comfy-api's
exclude list rewrites this section in place, and a change to the
PUBLISHED Router surface opens its own sync PR carrying the set as of
ITS commit. Once this PR is merged the note is a permanent snapshot —
for the current state, check services/comfy-api/drip/codegen.yaml in
Comfy-Org/cloud directly.

No code generation for this spec yet. Nothing in this repo
generates code from spec/router-openapi.yaml, so this sync has no low layer to
regenerate and the workflow that opened this pull request could not
prepare one for you.

That is not the same as nothing to do. This repo keeps a hand-written
surface coupled to this contract — its error-type class table — with
a drift check of its own, so a sync that adds an error bucket still
needs a commit here before this pull request goes green. When code
generation does land for this spec, its command is configured
upstream, in the same sync workflow that opened this PR, and this
section becomes the automatic one.

Summary by CodeRabbit

  • Documentation
    • Updated API documentation to describe canonical model IDs using the {provider}/{model} format.
    • Clarified model and provider path segment descriptions by removing references to an optional variant suffix.

@comfy-pr-bot
comfy-pr-bot requested review from a team as code owners September 14, 2026 06:47
@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 53e4f84b-34de-49fa-943b-e9eb93c6b894

📥 Commits

Reviewing files that changed from the base of the PR and between fffd414 and 8081ef3.

📒 Files selected for processing (1)
  • spec/router-openapi.yaml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The OpenAPI documentation now describes canonical model IDs as {provider}/{model} in the model and provider schemas and invocation path parameters.

Changes

Model ID documentation

Layer / File(s) Summary
Canonical model ID descriptions
spec/router-openapi.yaml
Updated RouterModelSegment, RouterProviderSegment, and invocation path parameter descriptions to remove the optional [/{variant}] suffix.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: mattmillerai

Merge Risk: ⚪ Minimal · up to 8081e

The OpenAPI descriptions now accurately document the supported provider/model format, with no identified merge-blocking risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: syncing the vendored Comfy Router specification from the specified source commit.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/sync-router-spec-4dc6e93

Comment @coderabbitai help to get the list of available commands.

@comfy-pr-bot

Copy link
Copy Markdown
Member Author

Superseded by #148 (chore/sync-router-spec-5a3b668), which vendors the Comfy Router spec projected from a newer source commit.

Every sync pull request on this branch prefix carries the FULL projected spec as of its own source commit, so the newer one contains everything this one did. Closing it automatically and deleting chore/sync-router-spec-4dc6e93; nothing here is lost, and the review to do is on #148.

A superseded sync pull request that carries a commit other than the sync bot's is never closed automatically — this one carried none.

@comfy-pr-bot
comfy-pr-bot deleted the chore/sync-router-spec-4dc6e93 branch September 14, 2026 17:02
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants