Cape Town| 26-ITP-May|Enice Mutanda| Sprint 3 |Practice-Tdd - #1531
Closed
Enice-Codes wants to merge 14 commits into
Closed
Cape Town| 26-ITP-May|Enice Mutanda| Sprint 3 |Practice-Tdd#1531Enice-Codes wants to merge 14 commits into
Enice-Codes wants to merge 14 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
Enice-Codes
added
📅 Sprint 3
hey-hammad
suggested changes
Jul 25, 2026
hey-hammad
left a comment
hey-hammad
left a comment
There was a problem hiding this comment.
Please review the exercise again and fix the implementation. Thanks
| } | ||
|
|
||
| module.exports = countChar; | ||
| test( "should count multiple occurrences of a character ", function(){ |
There was a problem hiding this comment.
all test are supposed to be in the .test.js file only
| // Given a string `str` and a single character `char` to search for, | ||
| // When the countChar function is called with these inputs, | ||
| // Then it should: | ||
| function CountChar(str, char) { |
There was a problem hiding this comment.
logic should be in .js file, here it should in the count.js file.
| @@ -3,3 +3,13 @@ function getOrdinalNumber(num) { | |||
There was a problem hiding this comment.
please implement the code logic for the function here.
Author
There was a problem hiding this comment.
hi @hey-hammad , i made corrections to the file and tested the code and it passed before pushing it on github.
hey-hammad
added
Review in progress
Enice-Codes
added
the
Needs Review
hey-hammad
added
Review in progress
hey-hammad
suggested changes
Aug 15, 2026
| expect(getOrdinalNumber(23)).toEqual("23rd"); | ||
| expect(getOrdinalNumber(143)).toEqual("143rd"); | ||
| }); | ||
|
No newline at end of file |
There was a problem hiding this comment.
consider adding more test cases regarding the edge case th i.e 11th, 12th etc
hey-hammad
added
Reviewed
Enice-Codes
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
Enice-Codes
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
Enice-Codes
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
Enice-Codes
added
the
Needs Review
hey-hammad
added
Complete
Member
|
Closing PR because the May ITP run has finished. Feel free to re-open if you're still working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Completed the card value exercise
the dependent file exercise
the dead code