chore(sdk): upgrade firewall manager sdk - #39
Merged
Merged
Conversation
Upgrade scc-firewall-manager-sdk to 1.22.1573 so inventory responses with UNKNOWN compliance and license statuses deserialize correctly. Refresh the lockfile and add regression coverage for the new contract.
huides00
requested review from
Scoombe,
afercal and
siddhuwarrier
as code owners
September 18, 2026 08:31
afercal
approved these changes
Sep 18, 2026
|
|
||
| def test_generated_sdk_is_pinned_to_the_verified_compatible_version() -> None: | ||
| assert "scc-firewall-manager-sdk==1.17.27" in _project_config()["dependencies"] | ||
| assert "scc-firewall-manager-sdk==1.22.1573" in _project_config()["dependencies"] |
Collaborator
There was a problem hiding this comment.
if there will be another change of this version, wouldn't it break the test again? Can we take it from somewhere in that case?
Collaborator
Author
There was a problem hiding this comment.
Good question. We should keep the SDK pinned to an exact version rather than always pulling the latest, because generated SDK releases can introduce breaking API changes and we want to catch that.
Use DeviceDeploymentsApi for multi-device FTD deployments introduced by SDK 1.22.1573 while retaining InventoryApi for single-device operations. Update regression tests and derive the SDK pin from pyproject so future upgrades do not duplicate the version string.
Add the 0.42.1 Ansible release entry required by release preparation so the next patch release preserves the existing changelog history.
Read the SDK requirement from the built package metadata instead of retaining the old version literal. Require one exact pin and verify the installed SDK matches it so future deliberate SDK bumps are validated automatically.
Consistency CheckNo consistency issues found. Checker output |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update the SCCFM SDK to support UNKNOWN compliance and license statuses returned by the API for devices whose licensing state cannot be determined. The lockfile and regression coverage are updated accordingly. The full offline test suite passes with 1660 tests.