Add Missing Architecture Versions for Nuget Package - #3815
Open
RubenCerna2079 wants to merge 2 commits into
Open
Add Missing Architecture Versions for Nuget Package#3815RubenCerna2079 wants to merge 2 commits into
RubenCerna2079 wants to merge 2 commits into
Conversation
1 task
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues were identified.
Pull request overview
Adds ARM64 runtime identifiers for Linux and macOS NuGet packaging.
Changes:
- Adds
linux-arm64andosx-arm64to the CLI project. - Adds matching identifiers to the Service project.
File summaries
| File | Summary |
|---|---|
src/Service/Azure.DataApiBuilder.Service.csproj |
Enables ARM64 service builds. |
src/Cli/Cli.csproj |
Enables ARM64 tool packaging. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why make this change?
What is this change?
This change adds the missing
linux-arm64andosx-arm-64versions to the RID (RuntimeIdentifier) in order to allow us to publish versions of the Nuget package that support those architectures.How was this tested?
Tested by creating a local nupkg to ensure all of the architectures are built correctly.
dotnet restore .\src\Azure.DataApiBuilder.sln --forcedotnet pack .\src\Cli\Cli.csproj