Skip to content

frontend: keep features modal visible after scrolled row clicks #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peterbarker merged 1 commit into from
Sep 15, 2026
Merged

frontend: keep features modal visible after scrolled row clicks #258

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions frontend/src/components/FeaturesModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,20 +472,32 @@ function FeatureRow({ feature, checked, onToggle, catHighlighted, innerRef, pend
: checked ? 'bg-yellow-400/5' : 'bg-transparent hover:bg-hover',
)}
>
<label className="flex items-start gap-3 px-5 py-3 cursor-pointer">
<div
role="checkbox"
aria-checked={checked}
aria-label={feature.name}
tabIndex={0}
className="flex items-start gap-3 px-5 py-3 cursor-pointer"
onKeyDown={e => {
if (e.key === ' ' || e.key === 'Enter') {
e.preventDefault();
if (!e.repeat) onToggle(feature.id);
}
}}
onClick={() => onToggle(feature.id)}
>
<div
className={clsx(
'w-4 h-4 rounded border mt-0.5 flex items-center justify-center shrink-0 transition-colors',
pendingUncheck
? 'dep-warn-check'
: checked ? 'bg-yellow-400 border-yellow-400' : 'border-surface-4',
)}
onClick={e => { e.preventDefault(); onToggle(feature.id); }}
aria-hidden
>
{checked && !pendingUncheck && <Check className="w-3 h-3 text-black" />}
{pendingUncheck && <Minus className="w-3 h-3 dep-warn-icon" />}
</div>
<input type="checkbox" className="sr-only" checked={checked} onChange={() => onToggle(feature.id)} />
<div className="flex-1 min-w-0">
<div className="flex items-center gap-2 flex-wrap">
<span className="text-sm font-medium text-gray-200">{feature.name}</span>
Expand All @@ -508,7 +520,7 @@ function FeatureRow({ feature, checked, onToggle, catHighlighted, innerRef, pend
<p className="text-xs text-gray-500 mt-0.5 leading-relaxed">{feature.description}</p>
)}
</div>
</label>
</div>

{pendingUncheck && activeDependents && activeDependents.length > 0 && (
<div className="dep-warn mx-5 mb-3 rounded-lg border overflow-hidden">
Expand Down
Loading