Skip to content

Stable 26.3 - port the ARM dremio guard and fix the ClickBench cache path #2413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MyroTk merged 2 commits into from
Sep 22, 2026
+11 −5
Merged

Stable 26.3 - port the ARM dremio guard and fix the ClickBench cache path #2413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2bbb484
Skip test_dremio_engine on ARM
CarlosFelipeOR Sep 21, 2026
4c2d531
Keep filesystem_caches_path out of the ClickBench override
CarlosFelipeOR Sep 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions ci/jobs/scripts/clickbench/filesystem_caches_path.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
<!--
The ClickBench `create.sql` attaches the `hits` table on a cached disk
rooted at `/dev/shm/clickhouse/`. The server validates that any
filesystem cache path lies inside `filesystem_caches_path` /
`custom_cached_disks_base_directory`, so point both at the same root.
rooted at `/dev/shm/clickhouse/`, and the server refuses a cache path
outside `custom_cached_disks_base_directory`, so point that at the same root.

Do not also move `filesystem_caches_path`: it is the root for the named
caches in `config.d/storage_conf_local.xml`, and relocating those to the
tmpfs on /dev/shm makes the server refuse to start, since their 21 GiB
`max_size` exceeds the tmpfs capacity.
-->
<clickhouse>
<filesystem_caches_path replace="replace">/dev/shm/clickhouse/</filesystem_caches_path>
<custom_cached_disks_base_directory replace="replace">/dev/shm/clickhouse/</custom_cached_disks_base_directory>
</clickhouse>
5 changes: 4 additions & 1 deletion tests/integration/test_dremio_engine/test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
import pytest
from helpers.client import QueryRuntimeException

from helpers.cluster import ClickHouseCluster
from helpers.cluster import ClickHouseCluster, is_arm
from helpers.config_cluster import dremio_user, dremio_pass

if is_arm():
pytestmark = pytest.mark.skip

cluster = ClickHouseCluster(__file__)
clickhouse_node = cluster.add_instance(
"node1",
Expand Down
Loading