Skip to content

Include resource managers in pathwaysutils profile request by default. - #325

Merged
copybara-service[bot] merged 1 commit into
mainfrom
test_982040855
Sep 16, 2026
Merged

copybara-service[bot] merged 1 commit into
mainfrom
test_982040855

Conversation

@wstcliyu

@wstcliyu wstcliyu commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator

Include resource managers in pathwaysutils profile request by default.

@google-cla

google-cla Bot commented Sep 15, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new boolean parameter include_resource_managers (defaulting to True) across the profiling utility functions, including start_trace, collect_profile, and the FastAPI ProfilingConfig. This allows users to control whether resource manager profiling is included in the JAX profile request. The corresponding unit tests have been updated and expanded to verify this new configuration option. There are no review comments, so I have no feedback to provide.

@copybara-service copybara-service Bot changed the title No public description Include resource managers in pathwaysutils profile request by default. Sep 16, 2026
@copybara-service
copybara-service Bot merged commit 67c531d into main Sep 16, 2026
39 of 40 checks passed
@copybara-service
copybara-service Bot deleted the test_982040855 branch September 16, 2026 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant