refactor(wallet): append the EIP-191 prefix directly - #1003
Merged
minhd-vu merged 2 commits intoSep 21, 2026
Merged
Conversation
minhd-vu
approved these changes
Sep 21, 2026
minhd-vu
left a comment
minhd-vu
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the contribution! 🔥
minhd-vu
enabled auto-merge (squash)
September 21, 2026 22:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Build the EIP-191 personal_sign prefix with fmt.Appendf instead of fmt.Sprintf followed by []byte conversion. The prefix bytes, message length encoding, and resulting Keccak-256 digest are unchanged.
Jira / Linear Tickets
N/A
Testing